Avoid app crashes if /customization/html/details folder is missing
#996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabhub
reviewed
Nov 7, 2023
frontend/src/services/getConfig.js
Outdated
| @@ -3,6 +3,9 @@ const deepmerge = require('deepmerge'); | |||
| const { getLocales } = require('./getLocales'); | |||
|
|
|||
| function getFiles(dir, files = []) { | |||
| if (!fs.existsSync(dir)) { | |||
There was a problem hiding this comment.
fs.existsSync() is the synchronous version of fs.exists().
fs.exists() is now deprecated and recommand using fs.stats() of fs.access() instead.
fs.stats() doesn't seems to have a sync version, but fs.access() does : fs.accessSync().
So it might be better to use fs.accessSync().
There was a problem hiding this comment.
Thanks for your advice 👍
I added a commit about it
mabhub
approved these changes
Nov 7, 2023
dtrucs
deleted the
Avoid-app-crashes-if-customization-html-details-folder-is-missing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 3.16.0, the app crashes on runtime if the
/customization/html/detailsfolder is missing